Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landmark Practice: Add note to prevent dialog content wrapped in a landmark #2818

Merged
merged 4 commits into from
Oct 24, 2023

Conversation

mcking65
Copy link
Contributor

@mcking65 mcking65 commented Oct 1, 2023

This PR replaces #2512 by @jnurthen, which was delayed due to the back-end refactor after the redesign launch.

The wording is different from that originally proposed by James; the intent is equivalent.

Preview Links

On both of the following pages, the changes is under the heading "General Principles of Landmark Design". The new content is the 4th bullet under step 2. None of the other content is changed by this PR.

Review checklist

Reviewers: To learn what needs to be covered by each review, Follow the link for the type of review to which you are assigned.


WAI Preview Link (Last built on Sun, 01 Oct 2023 04:42:40 GMT).

Copy link
Contributor

@a11ydoer a11ydoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The landmark clarification for modal looks good to me. Thanks, @mcking65

@mcking65
Copy link
Contributor Author

Thank you @jnurthen and @a11ydoer for the reviews.

@mcking65 mcking65 merged commit 9a5e55c into main Oct 24, 2023
19 checks passed
@mcking65 mcking65 deleted the landmark-dialog-note branch October 24, 2023 23:17
@mcking65 mcking65 added the enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy label Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants