Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landmark Example Pages: remove background colours that cause color contrast failures #2738

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

jnurthen
Copy link
Member

@jnurthen jnurthen commented Jun 27, 2023

resolves #2384

Review checklist

Reviewers: To learn what needs to be covered by each review, Follow the link for the type of review to which you are assigned.


WAI Preview Link (Last built on Tue, 27 Jun 2023 18:34:49 GMT).

@mcking65 mcking65 changed the title remove background colours where break contrast Landmark Example Pages: remove background colours that cause color contrast failures Jul 2, 2023
@mcking65 mcking65 added bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern labels Jul 2, 2023
@a11ydoer a11ydoer self-requested a review July 11, 2023 18:32
@css-meeting-bot
Copy link
Member

The ARIA Authoring Practices (APG) Task Force just discussed Landmark Example Pages: remove background colours that cause color contrast failures.

The full IRC log of that discussion <jugglinmike> Subtopic: Landmark Example Pages: remove background colours that cause color contrast failures
<jugglinmike> github: https://github.com//pull/2738
<jugglinmike> Matt_King: This is a small fix. I think we just need a visual review
<jugglinmike> Jem: I can do that. I'll assign myself
<jugglinmike> Matt_King: Thanks!

Copy link
Contributor

@a11ydoer a11ydoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preview of Landmark example is available at new build Background color which cause color contrast issue was removed.

@mcking65 mcking65 merged commit 7723165 into main Jul 24, 2023
19 checks passed
@mcking65 mcking65 deleted the jnurthen/issue2384-2 branch July 24, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern
Development

Successfully merging this pull request may close these issues.

Related Documents links - Insufficient contrast ratio
4 participants