Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AT Support tables for modal dialog, 1 slider, and navigation menu button #2736

Merged
merged 3 commits into from
Jul 24, 2023

Conversation

mcking65
Copy link
Contributor

@mcking65 mcking65 commented Jun 26, 2023

Adds AT support tables for three examples:

  • Color viewer slider
  • Modal dialog
  • Navigation menu button

Preview links

Review checklist


WAI Preview Link (Last built on Mon, 26 Jun 2023 15:52:29 GMT).

@mcking65 mcking65 added Example Page Related to a page containing an example implementation of a pattern documentation labels Jun 26, 2023
@mcking65 mcking65 added the enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy label Jun 26, 2023
@mcking65 mcking65 added this to the H1/2023 Content Updates milestone Jun 26, 2023
@css-meeting-bot
Copy link
Member

The ARIA Authoring Practices (APG) Task Force just discussed PR2736: Add AT Support tables for modal dialog, 1 slider, and navigation menu button by mcking65.

The full IRC log of that discussion <jugglinmike> subtopic: PR2736: Add AT Support tables for modal dialog, 1 slider, and navigation menu button by mcking65
<jugglinmike> github: https://github.com//pull/2736
<jugglinmike> Matt_King: There isn't much to review here. These three new support tables should look just like the others
<jugglinmike> Matt_King: The only difference is that I put these new ones higher on their pages
<jugglinmike> Matt_King: I think I'll just have Jemma look at this

@mcking65 mcking65 requested a review from a11ydoer July 10, 2023 20:55
Copy link
Contributor

@a11ydoer a11ydoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AT support tables for three examples look great. I am glad to see two different wordings of "not applicable" and "Data net yet available"

@css-meeting-bot
Copy link
Member

The ARIA Authoring Practices (APG) Task Force just discussed Add AT Support tables for modal dialog, 1 slider, and navigation menu button.

The full IRC log of that discussion <jugglinmike> Subtopic: Add AT Support tables for modal dialog, 1 slider, and navigation menu button
<jugglinmike> github: https://github.com//pull/2736
<jugglinmike> Matt_King: I'm not going to merge this until I receive a "go ahead" from Vispero, and I'm meeting with them tomorrow
<jugglinmike> Jem: I approved it yesterday

@mcking65 mcking65 merged commit 548d8f6 into main Jul 24, 2023
19 checks passed
@mcking65 mcking65 deleted the at-support-additions branch July 24, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Example Page Related to a page containing an example implementation of a pattern
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants