Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Open in Codepen" button to example that use Font Awesome for Icons #1685

Merged
merged 5 commits into from
May 4, 2021

Conversation

spectranaut
Copy link
Contributor

@spectranaut spectranaut commented Dec 15, 2020

This PR does three things:

  1. Adds font awesome icon stylesheet to Codepen options. Now, if font awesome is used in an example going forward, the icons will appear as expected when the example is opened in codepen.
  2. Adds the Open In Codepen button to the two examples that use font awesome already:
    1. toolbar/toolbar.html
    2. dialog-modal/datepicker-dialog.html
  3. Converts the treeview directory example to use font awesome icons for the folder and file icons and adds the "Open in Codepen" button to them:
    1. treeview/treeview-1/treeview-1a.html
    2. treeview/treeview-1/treeview-1b.html

@spectranaut spectranaut changed the title Add "Open in Codepen" button to example taht use Font Awesome for Icons Add "Open in Codepen" button to example that use Font Awesome for Icons Dec 15, 2020
Base automatically changed from master to main March 3, 2021 18:13
@zcorpan zcorpan force-pushed the codepen-fontawesome branch from f897a0d to f78cfc6 Compare April 19, 2021 20:16
Copy link
Member

@zcorpan zcorpan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and tested and rebased on current main. Looks good to me.

@mcking65 mcking65 added the agenda Include in upcoming Authoring Practices Task Force meeting label Apr 26, 2021
@a11ydoer a11ydoer self-requested a review April 30, 2021 20:12
Copy link
Contributor

@a11ydoer a11ydoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Font awesome icons look good in the Codepen example.

@mcking65 mcking65 added enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Example Page Related to a page containing an example implementation of a pattern and removed agenda Include in upcoming Authoring Practices Task Force meeting labels May 4, 2021
@mcking65 mcking65 added this to the 1.2 Release 1 milestone May 4, 2021
@mcking65 mcking65 merged commit eb663f3 into main May 4, 2021
@mcking65 mcking65 deleted the codepen-fontawesome branch May 4, 2021 14:37
kdoberst pushed a commit to kdoberst/aria-practices that referenced this pull request May 14, 2021
…esome for Icon (pull w3c#1685)

1. Adds font awesome icon stylesheet to Codepen options. Now, if font awesome is used in an example going forward, the icons will appear as expected when the example is opened in codepen. 
2. Adds the Open In Codepen button to the two examples that use font awesome already: toolbar/toolbar.html and dialog-modal/datepicker-dialog.html.
3. Converts the treeview directory example to use font awesome icons for the folder and file icons and adds the "Open in Codepen" button to them: treeview/treeview-1/treeview-1a.html and treeview/treeview-1/treeview-1b.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Example Page Related to a page containing an example implementation of a pattern
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants