Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guidelines for range related properties (replaced by #1279) #1000

Closed
wants to merge 5 commits into from

Conversation

spectranaut
Copy link
Contributor

@spectranaut spectranaut commented Mar 14, 2019

This PR is to get feedback on range related property section to add to the APG.


Preview | Diff

@spectranaut spectranaut changed the title Draft range related properties Guidelines for range related properties Mar 14, 2019
@css-meeting-bot
Copy link
Member

The ARIA Authoring Practices (APG) Task Force just discussed Range related properties guidance.

The full IRC log of that discussion <AnnAbbott> TOPIC: Range related properties guidance
<zcorpan> GitHub: https://github.com//pull/1000
<AnnAbbott> I'm back
<MarkMcCarthy> ey: above is a link to range related properties
<Jemma> https://github.com/w3c/aria-practices/blob/4207f97ceb0929ca8d9246d782f332c1b1573ef1/range_related_properties.md
<MarkMcCarthy> s/ey: above/ey: below
<AnnAbbott> mck: wants feedback on structure, missing info, where are others going to have questions
<AnnAbbott> jg: min/max not required on slider any longer
<Jemma> https://www.w3.org/TR/wai-aria-practices/examples/slider/slider-2.html
<Jemma> Slider Examples with aria-orientation and aria-valuetext
<AnnAbbott> jg: when has text value, numeric value doesn't make sense
<AnnAbbott> Simon: example doesn't use min/max
<zcorpan> s/doesn't/does/
<AnnAbbott> mck: high/med/low corresponds to 1, 2 and 3
<AnnAbbott> jg: there are good use cases for not having min/max
<AnnAbbott> jg: if something has text value, is it correct to use slider?
<AnnAbbott> Simon: where is an example without min/max?
<AnnAbbott> mck: what is purpose of min/max?
<AnnAbbott> jn: ARIA spec will not require min/max
<zcorpan> you can override the percentage rendering with aria-valuetext
<AnnAbbott> jn: if not specified, min = zero/max = 100
<AnnAbbott> mck: more work needed on this

@spectranaut spectranaut marked this pull request as ready for review June 26, 2019 11:56
@zcorpan
Copy link
Member

zcorpan commented Aug 30, 2019

I have converted this to HTML and rebased on master, but no new changes since @spectranaut had already addressed review feedback.

If this now looks OK, I think it should be ready for merge.

Here's a link to the preview of the new section.

@zcorpan zcorpan self-assigned this Nov 12, 2019
@zcorpan
Copy link
Member

zcorpan commented Nov 15, 2019

@jongund can you review this? Thanks!

@zcorpan
Copy link
Member

zcorpan commented Dec 3, 2019

Replacing this PR with #1279

@zcorpan zcorpan closed this Dec 3, 2019
@zcorpan zcorpan changed the title Guidelines for range related properties Guidelines for range related properties (replaced by #1279) Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants