Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update update-reference.js script to support APG site migration #1076

Merged
merged 6 commits into from
Jul 2, 2024

Conversation

howard-e
Copy link
Contributor

@howard-e howard-e commented Jun 3, 2024

Preview Tests

Addresses #1073.

This PR updates the npm run update-reference script to support the migration for example links in references.csv now that w3.org/WAI/ARIA/apg is being used in place of w3c.github.io/aria-practices.

@howard-e howard-e marked this pull request as ready for review June 3, 2024 16:36
@howard-e howard-e requested a review from stalgiag June 5, 2024 16:13
Copy link
Contributor

@stalgiag stalgiag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected. The code also makes sense. Small comment inline, not a blocker. Thank you!

@mcking65
Copy link
Contributor

mcking65 commented Jul 2, 2024

@ccanash @howard-e

Can this be merged? It is blocking work by PAC?

@howard-e howard-e merged commit 91a61c4 into master Jul 2, 2024
8 checks passed
@howard-e howard-e deleted the update-reference-script branch July 2, 2024 17:15
@howard-e
Copy link
Contributor Author

howard-e commented Jul 2, 2024

Can this be merged? It is blocking work by PAC?

Yep, I've merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants