Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make draft report links show in status dialog #985

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

alflennik
Copy link
Contributor

See #799, namely the comment from Matt:

Per my prior comment, I think this issue is not yet resolved because links to reports on draft test plans are still not available from the report status dialog.

In other words, when the test plan version is in the draft phase, the report status dialog on the data management page is not showing links to completed reports, instead it shows text like "100% complete by alflennik with 0 conflicts" even after being marked final. What it should show is "Report completed on Mar 26, 2024" which is a link to the completed report. Note that this feature does work for candidate and recommended test plan versions already.

I found in the code that we were intentionally not showing the links to reports that were still in draft, and I removed that bit of logic.

@alflennik alflennik requested review from evmiguel and Paul-Clue and removed request for evmiguel March 26, 2024 16:03
Copy link
Collaborator

@Paul-Clue Paul-Clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It runs as it should now showing the links to completed reports in report status dialogs for reports in the draft phase.

@Paul-Clue Paul-Clue merged commit f583e8f into main Mar 26, 2024
2 checks passed
@Paul-Clue Paul-Clue deleted the status-dialog-draft-report-link branch March 26, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants