Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: fixed the bikeshed errors #1715

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Editorial: fixed the bikeshed errors #1715

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
765a27a
Editorial: fixed the bikeshed errors
yoshisatoyanagisawa Apr 30, 2024
cf76bf0
Addressed the comment.
yoshisatoyanagisawa May 8, 2024
f0e08c0
Reflected the review comments.
yoshisatoyanagisawa May 9, 2024
57d7612
Omit " and a user agent-defined message".
yoshisatoyanagisawa May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions docs/index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1453,7 +1453,7 @@ spec: storage; urlPrefix: https://storage.spec.whatwg.org/
1. Run these substeps <a>in parallel</a>:
1. Let |newContext| be a new [=top-level browsing context=].
1. [=Queue a task=] to run the following steps on |newContext|'s {{Window}} object's [=environment settings object=]'s [=responsible event loop=] using the [=user interaction task source=]:
1. *HandleNavigate*: [=Navigate=] |newContext| to |url| with [=exceptionsEnabled=] true, and [=historyHandling=] "<code>replace</code>".
1. *HandleNavigate*: [=Navigate=] |newContext| to |url| with [=exceptionsEnabled=] true, and [=history handling behavior=] "<code>replace</code>".
yoshisatoyanagisawa marked this conversation as resolved.
Show resolved Hide resolved
1. If the algorithm steps invoked in the step labeled *HandleNavigate* [=throws=] an exception, [=queue a task=] to reject |promise| with the exception, on |serviceWorkerEventLoop| using the [=DOM manipulation task source=], and abort these steps.
1. Let |frameType| be the result of running [=Get Frame Type=] with |newContext|.
1. Let |visibilityState| be |newContext|'s <a>active document</a>'s {{Document/visibilityState}} attribute value.
Expand Down Expand Up @@ -2094,7 +2094,7 @@ spec: storage; urlPrefix: https://storage.spec.whatwg.org/
1. Invoke [=Batch Cache Operations=] with |operations|. If this [=throws=] an exception, set |errorData| to the exception.
1. [=Queue a task=], on |cacheJobPromise|'s [=relevant settings object=]'s [=responsible event loop=] using the [=DOM manipulation task source=], to perform the following substeps:
1. If |errorData| is null, resolve |cacheJobPromise| with undefined.
1. Else, reject |cacheJobPromise| with a [=exception/create|new=] [=exception=] with |errorData| and a user agent-defined [=exception/message=], in |realm|.
1. Else, reject |cacheJobPromise| with a [=exception/create|new=] [=exception=] with |errorData| and a user agent-defined [=DOMException/message=], in |realm|.
yoshisatoyanagisawa marked this conversation as resolved.
Show resolved Hide resolved
1. Return |cacheJobPromise|.
</section>

Expand Down Expand Up @@ -2139,7 +2139,7 @@ spec: storage; urlPrefix: https://storage.spec.whatwg.org/
1. Invoke [=Batch Cache Operations=] with |operations|. If this [=throws=] an exception, set |errorData| to the exception.
1. [=Queue a task=], on |cacheJobPromise|'s [=relevant settings object=]'s [=responsible event loop=] using the [=DOM manipulation task source=], to perform the following substeps:
1. If |errorData| is null, resolve |cacheJobPromise| with undefined.
1. Else, reject |cacheJobPromise| with a [=exception/create|new=] [=exception=] with |errorData| and a user agent-defined [=exception/message=], in |realm|.
1. Else, reject |cacheJobPromise| with a [=exception/create|new=] [=exception=] with |errorData| and a user agent-defined [=DOMException/message=], in |realm|.
</section>

<section algorithm="cache-delete">
Expand Down Expand Up @@ -2168,7 +2168,7 @@ spec: storage; urlPrefix: https://storage.spec.whatwg.org/
1. If |errorData| is null, then:
1. If |requestResponses| [=list/is not empty=], resolve |cacheJobPromise| with true.
1. Else, resolve |cacheJobPromise| with false.
1. Else, reject |cacheJobPromise| with a [=exception/create|new=] [=exception=] with |errorData| and a user agent-defined [=exception/message=], in |realm|.
1. Else, reject |cacheJobPromise| with a [=exception/create|new=] [=exception=] with |errorData| and a user agent-defined [=DOMException/message=], in |realm|.
1. Return |cacheJobPromise|.
</section>

Expand Down Expand Up @@ -2640,10 +2640,10 @@ spec: storage; urlPrefix: https://storage.spec.whatwg.org/
: Output
:: none

1. If |job|'s [=job/client=] is not null, [=queue a task=], on |job|'s [=job/client=]'s [=responsible event loop=] using the [=DOM manipulation task source=], to reject |job|'s [=job/job promise=] with a [=exception/create|new=] [=exception=] with |errorData| and a user agent-defined [=exception/message=], in |job|'s [=job/client=]'s [=environment settings object/Realm=].
1. If |job|'s [=job/client=] is not null, [=queue a task=], on |job|'s [=job/client=]'s [=responsible event loop=] using the [=DOM manipulation task source=], to reject |job|'s [=job/job promise=] with a [=exception/create|new=] [=exception=] with |errorData| and a user agent-defined [=DOMException/message=], in |job|'s [=job/client=]'s [=environment settings object/Realm=].
1. For each |equivalentJob| in |job|'s [=list of equivalent jobs=]:
1. If |equivalentJob|'s [=job/client=] is null, [=iteration/continue=].
1. [=Queue a task=], on |equivalentJob|'s [=job/client=]'s [=responsible event loop=] using the [=DOM manipulation task source=], to reject |equivalentJob|'s [=job/job promise=] with a [=exception/create|new=] [=exception=] with |errorData| and a user agent-defined [=exception/message=], in |equivalentJob|'s [=job/client=]'s [=environment settings object/Realm=].
1. [=Queue a task=], on |equivalentJob|'s [=job/client=]'s [=responsible event loop=] using the [=DOM manipulation task source=], to reject |equivalentJob|'s [=job/job promise=] with a [=exception/create|new=] [=exception=] with |errorData| and a user agent-defined [=DOMException/message=], in |equivalentJob|'s [=job/client=]'s [=environment settings object/Realm=].
</section>

<section algorithm>
Expand Down Expand Up @@ -3113,7 +3113,7 @@ spec: storage; urlPrefix: https://storage.spec.whatwg.org/
1. Otherwise, set |callback| to the result of [=convert to an ECMAScript value|converting to an ECMAScript value=] |eventListenerCallback|.
1. If [$IsCallable$](|callback|) is false, then return false.

Note: [=Event listener/Callback=] objects that use {{handleEvent}} are assumed to be non-empty. This avoids calling the {{handleEvent}} getters, which could modify the event listeners during this check.
Note: [=event listener/Callback=] objects that use <code>handleEvent</code> are assumed to be non-empty. This avoids calling the <code>handleEvent</code> getters, which could modify the event listeners during this check.
yoshisatoyanagisawa marked this conversation as resolved.
Show resolved Hide resolved

1. If |callback|'s [=function body=] is not empty (i.e. either a [=statement=] or [=declaration=] exist), then return false.

Expand Down
Loading