Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shouldn't InstallEvent has a constructor? #1713

Closed
skyclouds2001 opened this issue Apr 22, 2024 · 2 comments · Fixed by #1729
Closed

Shouldn't InstallEvent has a constructor? #1713

skyclouds2001 opened this issue Apr 22, 2024 · 2 comments · Fixed by #1729

Comments

@skyclouds2001
Copy link

skyclouds2001 commented Apr 22, 2024 •
edited
Loading

current the definition for InstallEvent does not has a constructor, this is different from other event interfaces and is quite uncommon, should it also define with a constructor, too?

image

relates with mdn/browser-compat-data#22870
@skyclouds2001 skyclouds2001 changed the title Should InstallEvent has a constructor Should InstallEvent has a constructor field Apr 22, 2024
@skyclouds2001 skyclouds2001 changed the title Should InstallEvent has a constructor field Shouldn't InstallEvent has a constructor? Aug 5, 2024
This was referenced Aug 5, 2024
Closed
Merged
@skyclouds2001
Copy link
Author

but interestingly, in browser implement InstallEvent is constructible

image

test in https://worker-playground.glitch.me/

@mkruisselbrink
Copy link
Collaborator

Yes, I believe this is an oversight in the spec that was missed when InstallEvent was added in #1701. I can't think of any reason why we shouldn't have a constructor.

sisidovski added a commit to sisidovski/ServiceWorker that referenced this issue Sep 27, 2024
@sisidovski
Add constructor to InstallEvent
b8bffc9 
Closes w3c#1713.
@sisidovski sisidovski mentioned this issue Sep 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add constructor to InstallEvent sisidovski/ServiceWorker
2 participants
@mkruisselbrink @skyclouds2001