-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"origin of a blob URL" is redundant/confusing #63
Comments
It's definitely confusing. Unfortunately currently the way the URL standard defines the origin of a blob URL does not always return the correct value, in particular for opaque origins (see whatwg/url#127). I think what we'll end up doing is store the origin of a blob URL in the Blob URL store and then using that from the URL standard to return the correct origin. But yes, there is lots of confusing, redundant and conflicting stuff with regard to blob URLs. |
* Stop using incumbent settings object Also adds a warning about #63. * "Issue" not "Warning" * Fix local builds and do Bikeshed rebuild
This fixes whatwg#290, fixes whatwg#127, fixes w3c/FileAPI#20 and fixes w3c/FileAPI#63.
This fixes whatwg#290, fixes whatwg#127, fixes w3c/FileAPI#20 and fixes w3c/FileAPI#63.
Also update "Origin of blob URLs" section since the algorithm that was there will be part of the URL spec instead. Part of the work to address #63
In particular some blob: URLs representing an opaque origin could still be same origin with something. That only works if the origin is stored somewhere and is not obtained from the URL. Tests: see #371 (comment). This fixes #127, fixes #290 , fixes w3c/FileAPI#20, and fixes w3c/FileAPI#63.
This is stated as a normative statement, implying to me that blob URL's have some special origin that must be set at creation time.
However, the origin of a blob URL is instead normatively determined via the URL Standard. So this is just a statement of fact about what happens to be true according to the below algorithm, which is what creates blob URLs.
So it should be changed to a statement of fact, instead of a "must":
Furthermore, this would be much clearer if instead of defining the new term "origin of a Blob URL", it just linked the first "origin" in this sentence to https://url.spec.whatwg.org/#concept-url-origin
The text was updated successfully, but these errors were encountered: