Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle errors from JSON serialization. #666

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Handle errors from JSON serialization. #666

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions spec/index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1208,6 +1208,7 @@ To <dfn>fetch an identity assertion</dfn> given a {{USVString}}
1. If |provider|'s {{IdentityProviderRequestOptions/params}} is not empty:
1. Let |json| be the result of [=serializing a JavaScript value to a JSON string=]
with |provider|'s {{IdentityProviderRequestOptions/params}}.
1. If serializing threw an exception, return failure.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be "through" instead of "threw"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be "through" instead of "threw"?

Nope. "Threw" is a past tense of "throw".

1. Append ("params", |json|) to |list|.
1. Let |requestBody| be the result of running [=urlencoded serializer=] with |list|.
1. Let |request| be a new <a spec=fetch for=/>request</a> as follows:
Expand Down
Loading