Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase test timeout to one minute #177

Merged
merged 1 commit into from
May 11, 2021

Conversation

clehner
Copy link
Member

@clehner clehner commented Apr 1, 2021

Close #173

@@ -1,7 +1,7 @@
const jest = require("jest");
const path = require("path");

const JEST_TEST_TIMEOUT_MS = 20 * 1000;
const JEST_TEST_TIMEOUT_MS = 60 * 1000;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotta give enough time for the hamsters to bring the wheels up to speed.

Copy link
Contributor

@OR13 OR13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not a good idea... we can't keep bumping the timeout to make up for the fact that we are testing dids that are slow, in a test suite about VCs.

All credentials issued by DIDs other than DID Key should be removed.

Copy link
Member

@peacekeeper peacekeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense, since this is for testing VCs, not DIDs. If someone has super slow DIDs but still produces valid VCs, then the tests should pass.

All credentials issued by DIDs other than DID Key should be removed.

I don't think it's fair to limit the test suite to only a single DID method (did:key), since not everyone may support that. I do think however that the reporting can be improved to count each test only once. I.e. if you configure 10 different issuer DIDs, the reporting should show the same number of tests as if you configure 1 issuer DID.

@OR13 OR13 merged commit 2408df9 into w3c-ccg:main May 11, 2021
@clehner clehner deleted the fix/increase-timeout branch May 11, 2021 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timeout resolving did:web
4 participants