Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor[venom]: refactor mem2var #4421

Merged
merged 3 commits into from
Dec 26, 2024

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Dec 22, 2024

What I did

How I did it

How to verify it

Commit message

remove special cases which were necessary before introduction of
`palloca`. now they represent useless variable read/writes which are
safe to remove. results in removal of a few instructions on benchmark
contracts.

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

charles-cooper and others added 3 commits December 21, 2024 15:12
remove special cases which were necessary before introduction of
palloca. now they represent useless variable read/writes which are safe
to remove. results in removal of a few instructions on benchmark
contracts.
Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.80%. Comparing base (c9d8f5b) to head (5129d3d).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
vyper/venom/passes/mem2var.py 90.47% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4421      +/-   ##
==========================================
- Coverage   91.78%   90.80%   -0.99%     
==========================================
  Files         119      119              
  Lines       16615    16615              
  Branches     2796     2794       -2     
==========================================
- Hits        15250    15087     -163     
- Misses        935     1063     +128     
- Partials      430      465      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charles-cooper charles-cooper merged commit 7caa055 into vyperlang:master Dec 26, 2024
156 of 158 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants