-
-
Notifications
You must be signed in to change notification settings - Fork 836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix[tool]: update VarAccess pickle implementation #4270
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
8e0ad30
fix[tool]: update VarAccess pickle implementation
charles-cooper 22ebb7d
add a test
charles-cooper a4d1ae4
update dict directly
charles-cooper 43ab3d0
use `object.__setattr__()`, it is more general and doesn't require `_…
charles-cooper a5f501c
Merge branch 'master' into fix/pickle
charles-cooper e1ebcb8
add a note
charles-cooper d5e78ec
Merge branch 'master' into fix/pickle
charles-cooper d3309e7
simplify `_produce()`
charles-cooper 15efb2e
revert VarAccess constructor API change
charles-cooper File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
import copy | ||
import pickle | ||
|
||
from vyper.compiler.phases import CompilerData | ||
|
||
|
||
def test_pickle_ast(): | ||
code = """ | ||
@external | ||
def foo(): | ||
self.bar() | ||
y: uint256 = 5 | ||
x: uint256 = 5 | ||
def bar(): | ||
pass | ||
""" | ||
f = CompilerData(code) | ||
copy.deepcopy(f.annotated_vyper_module) | ||
pickle.loads(pickle.dumps(f.annotated_vyper_module)) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could also use the following trick if all fields can be passed as keyword arguments to constructor in subclasses:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting, is there a performance difference?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be slower. The advantage is that you do not need to add private method
_produce()
.