Modification of abi format to include gas cost estimate for functions… #308
Conversation
viper/compiler.py
Outdated
| gas_estimates = gas_estimate(code) | ||
| for idx, func in enumerate(abi): | ||
| func_name = func['name'].split('(')[0] | ||
| print(func_name) |
|
Had to reorder the commits because I tried re-basing this branch and made a mistake. |
|
@vbuterin see any problems with this? |
|
@DavidKnott What do you think of this update? Is there a potential problem with adding a field to the ABI output? |
|
I don't think so, I'll look into it |
|
@fubuloubu I think as of now gas estimation isn't accurate enough to be included in the abi. Right now gas estimation fails on quite a few the tests in |
|
I think it would be easier to debug if that information was actually available in the ABI as it at least shows a bigger picture, and also if the gas estimation feature were working correctly then this update still works the same way and provides those more accurate updates in the same way. I don't believe this update creates any new bugs as it is fairly simple and unobtrusive, and #306 shows it is a useful feature to have in the long term. This is alpha software after all, no guarantees on correct output just yet. |
|
@fubuloubu Looked at this again and I think you're right, merging it in. |
… (skips constructor)