T7182: use Config instead of ConfigTreeQuery for get_interface_dict #4354
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change summary
The recent change to
vyos-netplug-dhcp-client
to useget_interface_dict
(T5103; 8faf67c) requires the use of Config over ConfigTreeQueery for full support of the underlyingget_config_dict
(namely, keyword argwith_pki
); this is preferred over extending ConfigTreeQuery at this time, as the latter is due for revision/simplification.It remains an open question, currently under investigation, as to why this is missed by smoketests, however, the above change is clearly needed for backport to follow 8faf67c in 1.4.2.
Types of changes
Related Task(s)
Related PR(s)
How to test / Smoketest result
Without change:
With fix:
Checklist: