Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webproxy: T7057: Fixed 'domain-nocache' command #4344

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

aapostoliuk
Copy link
Contributor

Change summary

Fixed 'domain-nocache' command.
Added config generation for this command.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

How to test / Smoketest result

CLI Configuration:

set service webproxy listen-address 192.168.139.145 disable-transparent
set service webproxy domain-noncache test1.net
set service webproxy domain-noncache test2.net
commit

Squid config part:

vyos@vyos:~$ cat /etc/squid/squid.conf
### generated by service_webproxy.py ###

...............

acl NOCACHE dstdomain ukr.net
acl NOCACHE dstdomain test.net
no_cache deny NOCACHE

.......................

Smoke test results

vyos@vyos:~$ cp test_service_webproxy.py  /usr/libexec/vyos/tests/smoke/cli/
cp: cannot create regular file '/usr/libexec/vyos/tests/smoke/cli/test_service_webproxy.py': Permission denied
vyos@vyos:~$ sudo cp test_service_webproxy.py  /usr/libexec/vyos/tests/smoke/cli/
vyos@vyos:~$ /usr/libexec/vyos/tests/smoke/cli/test_service_webproxy.py
test_01_basic_proxy (__main__.TestServiceWebProxy.test_01_basic_proxy) ... ok
test_02_advanced_proxy (__main__.TestServiceWebProxy.test_02_advanced_proxy) ... ok
test_03_ldap_proxy_auth (__main__.TestServiceWebProxy.test_03_ldap_proxy_auth) ... ok
test_04_cache_peer (__main__.TestServiceWebProxy.test_04_cache_peer) ... ok
test_05_basic_squidguard (__main__.TestServiceWebProxy.test_05_basic_squidguard) ... ok
test_07_nocache_domain_proxy (__main__.TestServiceWebProxy.test_07_nocache_domain_proxy) ... ok

----------------------------------------------------------------------
Ran 6 tests in 206.452s

OK

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@aapostoliuk aapostoliuk requested a review from a team as a code owner February 11, 2025 10:15
Copy link

github-actions bot commented Feb 11, 2025

👍
No issues in PR Title / Commit Title

Fixed 'domain-nocache' command.
Added config generation for this command.
Copy link

CI integration ❌ failed!

Details

CI logs

  • CLI Smoketests (no interfaces) ❌ failed
  • CLI Smoketests (interfaces only) ❌ failed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

@c-po c-po merged commit fba59f9 into vyos:current Feb 11, 2025
13 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants