Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T6946: add wrapper for show_commit_data and test function #4331

Draft
wants to merge 1 commit into
base: current
Choose a base branch
from

Conversation

jestabro
Copy link
Contributor

@jestabro jestabro commented Feb 3, 2025

Change summary

DRAFT pending update of
vyos/libvyosconfig#24
and docker image.

Add helper show_commit_data for comparison.

N.B. integration tests will fail until libvyosconfig and docker are updated appropriately, but all smoketests pass in local tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

How to test / Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@jestabro jestabro self-assigned this Feb 3, 2025
Copy link

github-actions bot commented Feb 3, 2025

👍
No issues in PR Title / Commit Title

Copy link

github-actions bot commented Feb 3, 2025

CI integration ❌ failed!

Details

CI logs

  • CLI Smoketests (no interfaces) ❌ failed
  • CLI Smoketests (interfaces only) 👍 passed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant