Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pki: T6241: remove debug print statement about updated subsystems #3657

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

c-po
Copy link
Member

@c-po c-po commented Jun 15, 2024

Change Summary

Commit 9f9891a ("pki: T6241: Fix dependency updates on PKI changes") added a print() statement which notified the users about the subsystems which got supplied with an updated certificate.

Example:

PKI: Updating config: interfaces openvpn vtun0 tls certificate openvpn_vtun0
PKI: Updating config: interfaces openvpn vtun0 tls ca_certificate openvpn_vtun0_1

This is an informational message which should maybe (if needed) be sent to syslog. But the main issue is that CLI paths are mangled (- to _) which makes the about print output wrong and could potentially confuse users.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe): Remove DEBUG code

Related Task(s)

Component(s) name

PKI

Proposed changes

Statement has been commented to be re-enabled for debugging.

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Commit 9f9891a ("pki: T6241: Fix dependency updates on PKI changes") added
a print() statement which notified the users about the subsystems which got
supplied with an updated certificate.

Example:
> PKI: Updating config: interfaces openvpn vtun0 tls certificate openvpn_vtun0
> PKI: Updating config: interfaces openvpn vtun0 tls ca_certificate openvpn_vtun0_1

This is an informational message which should maybe (if needed) be sent to
syslog. But the main issue is that CLI paths are mangled (- to _) which makes
the about print output wrong and could potentially confuse users.

Statement has been commented to be re-enabled for debugging.
@c-po c-po requested a review from a team as a code owner June 15, 2024 20:22
@c-po
Copy link
Member Author

c-po commented Jun 15, 2024

@Mergifyio backport sagitta

Copy link

github-actions bot commented Jun 15, 2024

👍
No issues in PR Title / Commit Title

Copy link
Contributor

mergify bot commented Jun 15, 2024

backport sagitta

✅ Backports have been created

@c-po c-po enabled auto-merge June 16, 2024 07:24
@c-po c-po merged commit 13c786c into vyos:current Jun 17, 2024
10 checks passed
@dmbaturin
Copy link
Member

@Mergifyio backport sagitta-stream

@dmbaturin
Copy link
Member

@Mergifyio backport circinus-stream

Copy link
Contributor

mergify bot commented Jun 17, 2024

backport sagitta-stream

✅ Backports have been created

Copy link
Contributor

mergify bot commented Jun 17, 2024

backport circinus-stream

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants