Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T5853: Typo correction interfaces-virtual-ethernet.xml.in #2678

Merged
merged 1 commit into from
Dec 24, 2023

Conversation

zero13th
Copy link
Contributor

@zero13th zero13th commented Dec 23, 2023

Change Summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):Typo

Related Task(s)

Related PR(s)

Component(s) name

Proposed changes

How to test

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, jestabro, sever-sever and c-po and removed request for a team December 23, 2023 19:52
Copy link
Member

@sever-sever sever-sever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should refer to the task ID on https://vyos.dev
Also task number should be in the commit message
read please https://github.com/vyos/vyos-1x/blob/current/CONTRIBUTING.md

@zero13th zero13th changed the title typo correction interfaces-virtual-ethernet.xml.in T5853: Typo correction interfaces-virtual-ethernet.xml.in Dec 23, 2023
@sever-sever
Copy link
Member

Could you also change and the commit message?
You can use “git comment —amend” and “git push —force”

@c-po c-po merged commit 89cd75b into vyos:current Dec 24, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants