Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T5804: nat: remove inbound|outbound interface from old configuration when it was set to <any>. #2611

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

nicolas-fort
Copy link
Contributor

Change Summary

In older version, it was mandatory to define inbound or outbound interface in NAT rules. If desired, user could used interface for matching on every interface.
Since that requirement was removed, we also removed the possibility for using . In order to accomplish that requirement, user must omit using inbound|outbound interface matcher.
As done for other matching criteria, if it's not specified, that it's valid for all!

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

#2579

Component(s) name

nat

Proposed changes

How to test

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@dmbaturin dmbaturin merged commit a2b9477 into vyos:current Dec 12, 2023
@nicolas-fort
Copy link
Contributor Author

Backport?

@sever-sever
Copy link
Member

@Mergifyio backport sagitta

Copy link
Contributor

mergify bot commented Dec 21, 2023

backport sagitta

✅ Backports have been created

c-po added a commit that referenced this pull request Dec 21, 2023
T5804: nat: remove inbound|outbound interface from old configuration when it was set to <any>. (backport #2611)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants