Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: only high values can be removed #1

Closed
lvlvllvlvllvlvl opened this issue May 23, 2023 · 1 comment
Closed

bug: only high values can be removed #1

lvlvllvlvllvlvl opened this issue May 23, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@lvlvllvlvllvlvl
Copy link

line 95 should be if abs(first_element - sample_mean) > abs(last_element - sample_mean): to find the candidate that is furthest from the mean. as it is it always evaluates false
vvaezian added a commit that referenced this issue May 23, 2023
@vvaezian
Fix issue #1
8b61fb4
@vvaezian vvaezian added the bug Something isn't working label May 23, 2023
@vvaezian
Copy link
Owner

Hi @lvlvllvlvllvlvl Thanks for the catch. It's now fixed in version 0.1.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vvaezian @lvlvllvlvllvlvl