Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/validator manual #47

Merged
merged 4 commits into from
Aug 28, 2019
Merged

Feature/validator manual #47

merged 4 commits into from
Aug 28, 2019

Conversation

th3ee-pop
Copy link
Contributor

📝 Update U-Validator rules' doc
✨ Add "manual" property to U-Validator, since U-Chips need it to fulfill manual validation.

@th3ee-pop th3ee-pop requested a review from z-ZYS-s August 23, 2019 09:39
Copy link
Member

@z-ZYS-s z-ZYS-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noDuplicates 好像没有

@@ -26,6 +26,7 @@ export const UValidator = {
validatingOptions: Object,
validatingValue: null,
validatingProcess: { type: Function, default: (value) => value },
manual: { type: Boolean, default: false },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manual 补充一下 api 文档

@z-ZYS-s
Copy link
Member

z-ZYS-s commented Aug 26, 2019

@types那边提个 PR,在这里关联一下

@th3ee-pop
Copy link
Contributor Author

关于@types/validator的issue。
typed-typings/validator#11
看了一下,最后的更新来自2017年6月,之后也有人提出issue,但是没有被理会。今天晚上我再提个pr等等看好了。

@z-ZYS-s
Copy link
Member

z-ZYS-s commented Aug 26, 2019

好的,明天看一下有没有动静,没有的话,我就先合了

@z-ZYS-s z-ZYS-s merged commit 0f7d7f8 into next Aug 28, 2019
@z-ZYS-s z-ZYS-s deleted the feature/validator-manual branch September 9, 2019 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants