Skip to content

Commit

Permalink
Fix FetchAtomService content type handling (mastodon#9132)
Browse files Browse the repository at this point in the history
* Add profile to json+ld in Accept

It's required by the ActivityPub spec

* Use headers['Content-type'] instead of mime_type

mime_type strips the profile from the content type, but it's still available raw in the headers hash

* Add test for ld+json with profile
  • Loading branch information
valerauko authored and Gargron committed Oct 30, 2018
1 parent a3d40ba commit c36a4a1
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 5 deletions.
10 changes: 6 additions & 4 deletions app/services/fetch_atom_service.rb
Original file line number Diff line number Diff line change
Expand Up @@ -29,17 +29,19 @@ def process(url, terminal = false)

def perform_request(&block)
accept = 'text/html'
accept = 'application/activity+json, application/ld+json, application/atom+xml, ' + accept unless @unsupported_activity
accept = 'application/activity+json, application/ld+json; profile="https://www.w3.org/ns/activitystreams", application/atom+xml, ' + accept unless @unsupported_activity

Request.new(:get, @url).add_headers('Accept' => accept).perform(&block)
end

def process_response(response, terminal = false)
return nil if response.code != 200

if response.mime_type == 'application/atom+xml'
response_type = response.headers['Content-type']

if response_type == 'application/atom+xml'
[@url, { prefetched_body: response.body_with_limit }, :ostatus]
elsif ['application/activity+json', 'application/ld+json; profile="https://www.w3.org/ns/activitystreams"'].include?(response.mime_type)
elsif ['application/activity+json', 'application/ld+json; profile="https://www.w3.org/ns/activitystreams"'].include?(response_type)
body = response.body_with_limit
json = body_to_json(body)
if supported_context?(json) && equals_or_includes_any?(json['type'], ActivityPub::FetchRemoteAccountService::SUPPORTED_TYPES) && json['inbox'].present?
Expand All @@ -55,7 +57,7 @@ def process_response(response, terminal = false)

if link_header&.find_link(%w(rel alternate))
process_link_headers(link_header)
elsif response.mime_type == 'text/html'
elsif response_type == 'text/html'
process_html(response)
end
end
Expand Down
9 changes: 8 additions & 1 deletion spec/services/fetch_atom_service_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -60,13 +60,20 @@
it { is_expected.to eq [url, { :prefetched_body => "" }, :ostatus] }
end

context 'content_type is json' do
context 'content_type is activity+json' do
let(:content_type) { 'application/activity+json' }
let(:body) { json }

it { is_expected.to eq [1, { prefetched_body: body, id: true }, :activitypub] }
end

context 'content_type is ld+json with profile' do
let(:content_type) { 'application/ld+json; profile="https://www.w3.org/ns/activitystreams"' }
let(:body) { json }

it { is_expected.to eq [1, { prefetched_body: body, id: true }, :activitypub] }
end

before do
WebMock.stub_request(:get, url).to_return(status: 200, body: body, headers: headers)
WebMock.stub_request(:get, 'http://example.com/foo').to_return(status: 200, body: json, headers: { 'Content-Type' => 'application/activity+json' })
Expand Down

0 comments on commit c36a4a1

Please sign in to comment.