-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Taproot support #198
Merged
Merged
Taproot support #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
CI is passing locally, will add the PR changes + psetv2 taproot support to #189 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Taproot/Tapscript support for elements, greatly inspired by the work already done on btcd: btcsuite/btcd#1787
1. bump btcd to latest, drop btcutils
btcsuite/btcd
(including taproot PRs + schnorr support), go mod is pointing the latest commit hash. It seems to me that taproot changes has not been released yet (Am I wrong ?).2. Elements taproot
taproot
package extends thebtcd/txscript/taproot
file and reuses the same unit test filetaproot_test.go
. Lot of copy-paste there, the logic is the same on Elements. The major change is about BIP-341 hash tags (suffixed by "/elements" on Liquid).payment
pkg implements several new functions in order to support P2TR payments (unconfidential/confidential).blech32
supports segwit v1 encoding (bech32m) + BONUS: add unit tests from liquidjs-libtransaction
pkg implementsHashForWitnessV1
.address
pkg (getScriptType, toOutputScript etc...).it closes #172
duplicate of #195
@altafan @tiero please review