Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix future object safety of BufferAccess #966

Merged
merged 1 commit into from
Jun 5, 2018
Merged

Fix future object safety of BufferAccess #966

merged 1 commit into from
Jun 5, 2018

Commits on May 30, 2018

  1. Fix future object safety of BufferAccess 

    It was recently discovered in rust-lang/rust#50781 that `Self: Trait` bounds in trait methods are really not object-safe. This will be made into a warning by rust-lang/rust#50966, and vulkano will be affected by the warning .

Thankfully the fix looks simple, by just moving `fn len` from `BufferAccess` to being directly in `TypedBufferAccess`.
    @leoyvens
    leoyvens committed May 30, 2018
    Configuration menu
    Copy the full SHA
    f287273 View commit details
    Browse the repository at this point in the history