Receipt logs #27
Merged
Receipt logs #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… so that when we encode it we don't need a LinkSystem/BlockReadOpener to iterte over the linked LogTrie and collect the logs for packing into the receipt consensus encoding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #25
Update Receipt codec so that when representing receipts as IPLD, we compose the list of logs into a MMPT and link to the root of this trie from the receipt node. We continue to store the Logs as a list in the node, as well, so that we can perform the proper encoding without needing a LinkSystem/BlockReadOpener to decompose the log trie back into a list.
New codecs for Log and LogTrie. When importing ethereum data into IPLD we now need to publish (and index) Log and LogTrie IPLD objects, as part of Separate out logs into own table cerc-io/go-ethereum#79.