Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config setting for display of items without barcodes. #2553

Merged

Conversation

demiankatz
Copy link
Member

@demiankatz demiankatz commented Sep 26, 2022

This was implemented in response to discussion #2548.

TODO:

  • Discuss name/placement of setting
  • Discuss whether/how to impact status-full.phtml
  • Add test coverage for new helper
  • Update changelog to note changed behavior when merging

@demiankatz
Copy link
Member Author

Based on discussion on #2548, I'm beginning to think that the best approach here is:

1.) Change the default behavior to allow empty barcodes (which will require a changelog note, but will also eliminate the inconsistency of behavior between holdings view and full status display).

2.) Add a note to the config file indicating that advanced filtering can be achieved by overriding/extending the holdings view helpers.

I'm definitely interested in other people's opinions on this!

@demiankatz
Copy link
Member Author

As suggested above, I've gone ahead and added expanded comments while flipping the default behavior. I still need to write a test for the new helper, which I will do once the basic approach is agreed upon.

Copy link
Contributor

@EreMaijala EreMaijala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@demiankatz
Copy link
Member Author

Thanks @EreMaijala (and @damien-git). I've added a test and updated the changelog, so I think this is clear to merge now!

@demiankatz demiankatz merged commit a3264e4 into vufind-org:dev Sep 29, 2022
EreMaijala pushed a commit to EreMaijala/vufind that referenced this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants