VUFIND-308 - QR Code Support #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VUFIND-308
|
Still working on fixing some JS issues where the text reverts to the non human readable when clicked |
|
Would it be better to not actually include anything other than a link to the Catalog Record? The reason I ask is it gives an incomplete link now. Can be fixed this $this->serverUrl(...) but then the reader doesn't recognize this as a valid URL because of all the extra data about the author and such afterwards. Let me know and I can probably fix it up. |
Resolves VUFIND-868. Thanks to Michael Wiesen for the fix.
- Added support for char fields - Started leveraging framework for escaping
Thanks to Chris Hallberg for identifying the problem.
…owing the user to pull up all the details
VUFIND-308
…owing the user to pull up all the details
… VUFIND-308-QRSupport
|
managed to break this PR i think |
|
Superseeded by #20 |
EreMaijala
added a commit
to EreMaijala/vufind
that referenced
this pull request
Jun 17, 2015
Improve compression of record images.
skellamp
added a commit
to skellamp/vufind
that referenced
this pull request
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds QR Code Support.
Only thing that I would do is try and make the QR code actually link to the Catalog Record.