feat(useAxios): Add types and callback to handle AxiosError #4653
+57
−32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
fixes #123
).Description
This PR introduces a generic type system for the AxiosError, in detail:
axiosError
ref that will be populated only when theError
is an instance ofAxiosError
, furthermore when the error is not AxiosError, theerror
ref will still be populated, and I also added a callback (onAxiosError
) that will be executed only when we have anAxiosError
, if that is the case, also theonError
callback will be executed.AxiosError
, basically, according to me, the developer is mainly looking for thedata
property of the error response, and, also for consistency with thedata
property of a successfulAxiosResponse
, I added a computed propertyaxiosErrorResponseData
that returns exactly the data of the error response.Example usage
Additional context
If the feature is accepted, I will add tests and update the docs. There is no breaking change in the composable, but only in the types, as it seems unavoidable.
Let me know if the naming is fine, I think they are pretty descriptive, but I'm looking forward to suggestions, if any.