Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add utils for types #211

Merged
merged 2 commits into from
Jul 9, 2024
Merged

fix: add utils for types #211

merged 2 commits into from
Jul 9, 2024

Conversation

heygsc
Copy link
Contributor

@heygsc heygsc commented Jul 9, 2024

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSDoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

same function

https://github.com/vueuse/vueuse/blob/main/packages/shared/utils/index.ts#L115

more information

microsoft/TypeScript#35101

📝 Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@heygsc heygsc changed the title Type feature fix: types(feature) Jul 9, 2024
@heygsc heygsc changed the title fix: types(feature) fix(feat): types Jul 9, 2024
@heygsc heygsc changed the title fix(feat): types fix: add utils for types Jul 9, 2024
BobbieGoede
BobbieGoede approved these changes Jul 9, 2024
View reviewed changes
Copy link
Collaborator

@BobbieGoede BobbieGoede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@BobbieGoede BobbieGoede merged commit 4c0fd3b into vueuse:main Jul 9, 2024
5 checks passed
@heygsc heygsc deleted the type-feature branch July 10, 2024 02:17
@Tomut0 Tomut0 mentioned this pull request Sep 27, 2024
Merged
@Tomut0 Tomut0 mentioned this pull request Oct 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BobbieGoede BobbieGoede BobbieGoede approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heygsc @BobbieGoede