Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow tags insertion before </body> #67

Merged
merged 6 commits into from
Jul 29, 2022
Merged

feat: allow tags insertion before </body> #67

merged 6 commits into from
Jul 29, 2022

Conversation

huang-julien
Copy link
Contributor

@huang-julien huang-julien commented May 21, 2022 •
edited
Loading

🔗 Linked issue

resolve nuxt/framework#53 , linked to nuxt/nuxt#13991 , linked to nuxt/nuxt#13345

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Allow adding tags before the end of </body> . For now, there is no restriction on the tag type.

@huang-julien huang-julien marked this pull request as draft May 21, 2022 18:39
@huang-julien huang-julien marked this pull request as ready for review May 21, 2022 19:18
@huang-julien huang-julien marked this pull request as draft May 21, 2022 19:22
@huang-julien huang-julien marked this pull request as ready for review May 21, 2022 20:10
danielroe
danielroe reviewed Jul 28, 2022
View reviewed changes
Copy link
Contributor

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice enhancement. Spotted a couple of lint issues; there might be more, but hopefully this helps.

What do you think @antfu?

src/create-element.ts Outdated Show resolved Hide resolved
src/create-element.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
huang-julien and others added 2 commits July 28, 2022 22:42
@huang-julien @danielroe
style: lint
9de58f5 
Co-authored-by: Daniel Roe <daniel@roe.dev>
@huang-julien
style: lint
2e1e0dc
@antfu antfu merged commit c5eed67 into vueuse:main Jul 29, 2022
This was referenced Jul 30, 2022
Closed
Merged
This was referenced Aug 2, 2022
Closed
Merged
@danielroe danielroe mentioned this pull request Sep 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe left review comments

@antfu antfu antfu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huang-julien @antfu @danielroe