Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V-Menu] Use always display: block; #4546

Closed
wants to merge 1 commit into from
Closed

[V-Menu] Use always display: block; #4546

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/VMenu/VMenu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ export default {
const data = {
staticClass: 'v-menu',
style: {
display: this.fullWidth ? 'block' : 'inline-block'
display: 'block'
},
directives: [{
arg: 500,
Expand Down
8 changes: 4 additions & 4 deletions test/unit/components/VDataIterator/__snapshots__/VDataIterator.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ exports[`VDataIterator.js should match a snapshot - footer slot 1`] = `
<div class="v-input__control">
<div class="v-input__slot">
<div class="v-menu"
style="display: inline-block;"
style="display: block;"
>
<div class="v-menu__activator">
<div class="v-select__slot">
Expand Down Expand Up @@ -161,7 +161,7 @@ exports[`VDataIterator.js should match a snapshot - no data 1`] = `
<div class="v-input__control">
<div class="v-input__slot">
<div class="v-menu"
style="display: inline-block;"
style="display: block;"
>
<div class="v-menu__activator">
<div class="v-select__slot">
Expand Down Expand Up @@ -295,7 +295,7 @@ exports[`VDataIterator.js should match a snapshot - no matching records 1`] = `
<div class="v-input__control">
<div class="v-input__slot">
<div class="v-menu"
style="display: inline-block;"
style="display: block;"
>
<div class="v-menu__activator">
<div class="v-select__slot">
Expand Down Expand Up @@ -433,7 +433,7 @@ exports[`VDataIterator.js should match a snapshot - with data 1`] = `
<div class="v-input__control">
<div class="v-input__slot">
<div class="v-menu"
style="display: inline-block;"
style="display: block;"
>
<div class="v-menu__activator">
<div class="v-select__slot">
Expand Down
6 changes: 3 additions & 3 deletions test/unit/components/VDataTable/__snapshots__/VDataTable.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ exports[`VDataTable.vue should match a snapshot - no data 1`] = `
<div class="v-input__control">
<div class="v-input__slot">
<div class="v-menu"
style="display: inline-block;"
style="display: block;"
>
<div class="v-menu__activator">
<div class="v-select__slot">
Expand Down Expand Up @@ -259,7 +259,7 @@ exports[`VDataTable.vue should match a snapshot - no matching results 1`] = `
<div class="v-input__control">
<div class="v-input__slot">
<div class="v-menu"
style="display: inline-block;"
style="display: block;"
>
<div class="v-menu__activator">
<div class="v-select__slot">
Expand Down Expand Up @@ -446,7 +446,7 @@ exports[`VDataTable.vue should match a snapshot - with data 1`] = `
<div class="v-input__control">
<div class="v-input__slot">
<div class="v-menu"
style="display: inline-block;"
style="display: block;"
>
<div class="v-menu__activator">
<div class="v-select__slot">
Expand Down
56 changes: 28 additions & 28 deletions test/unit/components/VMenu/__snapshots__/VMenu.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
exports[`VMenu.js should render component with custom absolute and match snapshot 1`] = `

<div class="v-menu"
style="display: inline-block;"
style="display: block;"
>
<div class="v-menu__content"
style="max-height: auto; min-width: 0px; max-width: auto; top: 12px; left: 0px; z-index: 0; display: none;"
Expand All @@ -16,7 +16,7 @@ exports[`VMenu.js should render component with custom absolute and match snapsho
exports[`VMenu.js should render component with custom activator and match snapshot 1`] = `

<div class="v-menu"
style="display: inline-block;"
style="display: block;"
>
<div class="v-menu__content"
style="max-height: auto; min-width: 0px; max-width: auto; top: 12px; left: 0px; z-index: 0; display: none;"
Expand All @@ -29,7 +29,7 @@ exports[`VMenu.js should render component with custom activator and match snapsh
exports[`VMenu.js should render component with custom auto and match snapshot 1`] = `

<div class="v-menu"
style="display: inline-block;"
style="display: block;"
>
<div class="v-menu__content v-menu__content--auto"
style="max-height: 200px; min-width: 16px; max-width: auto; top: 12px; left: 12px; z-index: 0; display: none;"
Expand All @@ -42,7 +42,7 @@ exports[`VMenu.js should render component with custom auto and match snapshot 1`
exports[`VMenu.js should render component with custom bottom and match snapshot 1`] = `

<div class="v-menu"
style="display: inline-block;"
style="display: block;"
>
<div class="v-menu__content"
style="max-height: auto; min-width: 0px; max-width: auto; top: 12px; left: 0px; z-index: 0; display: none;"
Expand All @@ -55,7 +55,7 @@ exports[`VMenu.js should render component with custom bottom and match snapshot
exports[`VMenu.js should render component with custom closeOnClick and match snapshot 1`] = `

<div class="v-menu"
style="display: inline-block;"
style="display: block;"
>
<div class="v-menu__content"
style="max-height: auto; min-width: 0px; max-width: auto; top: 12px; left: 0px; z-index: 0; display: none;"
Expand All @@ -68,7 +68,7 @@ exports[`VMenu.js should render component with custom closeOnClick and match sna
exports[`VMenu.js should render component with custom closeOnContentClick and match snapshot 1`] = `

<div class="v-menu"
style="display: inline-block;"
style="display: block;"
>
<div class="v-menu__content"
style="max-height: auto; min-width: 0px; max-width: auto; top: 12px; left: 0px; z-index: 0; display: none;"
Expand All @@ -81,7 +81,7 @@ exports[`VMenu.js should render component with custom closeOnContentClick and ma
exports[`VMenu.js should render component with custom disabled and match snapshot 1`] = `

<div class="v-menu"
style="display: inline-block;"
style="display: block;"
>
<div class="v-menu__content"
style="max-height: auto; min-width: 0px; max-width: auto; top: 12px; left: 0px; z-index: 0; display: none;"
Expand All @@ -107,7 +107,7 @@ exports[`VMenu.js should render component with custom fullWidth and match snapsh
exports[`VMenu.js should render component with custom lazy and match snapshot 1`] = `

<div class="v-menu"
style="display: inline-block;"
style="display: block;"
>
<div class="v-menu__content"
style="max-height: auto; min-width: 0px; max-width: auto; top: 12px; left: 0px; z-index: 0; display: none;"
Expand All @@ -120,7 +120,7 @@ exports[`VMenu.js should render component with custom lazy and match snapshot 1`
exports[`VMenu.js should render component with custom left and match snapshot 1`] = `

<div class="v-menu"
style="display: inline-block;"
style="display: block;"
>
<div class="v-menu__content"
style="max-height: auto; min-width: 0px; max-width: auto; top: 12px; left: 0px; z-index: 0; display: none;"
Expand All @@ -133,7 +133,7 @@ exports[`VMenu.js should render component with custom left and match snapshot 1`
exports[`VMenu.js should render component with custom maxHeight and match snapshot 1`] = `

<div class="v-menu"
style="display: inline-block;"
style="display: block;"
>
<div class="v-menu__content"
style="max-height: 100px; min-width: 0px; max-width: auto; top: 12px; left: 0px; z-index: 0; display: none;"
Expand All @@ -146,7 +146,7 @@ exports[`VMenu.js should render component with custom maxHeight and match snapsh
exports[`VMenu.js should render component with custom maxWidth and match snapshot 1`] = `

<div class="v-menu"
style="display: inline-block;"
style="display: block;"
>
<div class="v-menu__content"
style="max-height: auto; min-width: 0px; max-width: 100px; top: 12px; left: 0px; z-index: 0; display: none;"
Expand All @@ -159,7 +159,7 @@ exports[`VMenu.js should render component with custom maxWidth and match snapsho
exports[`VMenu.js should render component with custom minWidth and match snapshot 1`] = `

<div class="v-menu"
style="display: inline-block;"
style="display: block;"
>
<div class="v-menu__content"
style="max-height: auto; min-width: 100px; max-width: auto; top: 12px; left: 0px; z-index: 0; display: none;"
Expand All @@ -172,7 +172,7 @@ exports[`VMenu.js should render component with custom minWidth and match snapsho
exports[`VMenu.js should render component with custom nudgeBottom and match snapshot 1`] = `

<div class="v-menu"
style="display: inline-block;"
style="display: block;"
>
<div class="v-menu__content"
style="max-height: auto; min-width: 0px; max-width: auto; top: 100px; left: 0px; z-index: 0; display: none;"
Expand All @@ -185,7 +185,7 @@ exports[`VMenu.js should render component with custom nudgeBottom and match snap
exports[`VMenu.js should render component with custom nudgeLeft and match snapshot 1`] = `

<div class="v-menu"
style="display: inline-block;"
style="display: block;"
>
<div class="v-menu__content"
style="max-height: auto; min-width: 0px; max-width: auto; top: 12px; left: 12px; z-index: 0; display: none;"
Expand All @@ -198,7 +198,7 @@ exports[`VMenu.js should render component with custom nudgeLeft and match snapsh
exports[`VMenu.js should render component with custom nudgeRight and match snapshot 1`] = `

<div class="v-menu"
style="display: inline-block;"
style="display: block;"
>
<div class="v-menu__content"
style="max-height: auto; min-width: 0px; max-width: auto; top: 12px; left: 100px; z-index: 0; display: none;"
Expand All @@ -211,7 +211,7 @@ exports[`VMenu.js should render component with custom nudgeRight and match snaps
exports[`VMenu.js should render component with custom nudgeTop and match snapshot 1`] = `

<div class="v-menu"
style="display: inline-block;"
style="display: block;"
>
<div class="v-menu__content"
style="max-height: auto; min-width: 0px; max-width: auto; top: 12px; left: 0px; z-index: 0; display: none;"
Expand All @@ -224,7 +224,7 @@ exports[`VMenu.js should render component with custom nudgeTop and match snapsho
exports[`VMenu.js should render component with custom nudgeWidth and match snapshot 1`] = `

<div class="v-menu"
style="display: inline-block;"
style="display: block;"
>
<div class="v-menu__content"
style="max-height: auto; min-width: 100px; max-width: auto; top: 12px; left: 0px; z-index: 0; display: none;"
Expand All @@ -237,7 +237,7 @@ exports[`VMenu.js should render component with custom nudgeWidth and match snaps
exports[`VMenu.js should render component with custom offsetX and match snapshot 1`] = `

<div class="v-menu"
style="display: inline-block;"
style="display: block;"
>
<div class="v-menu__content"
style="max-height: auto; min-width: 0px; max-width: auto; top: 12px; left: 0px; z-index: 0; display: none;"
Expand All @@ -250,7 +250,7 @@ exports[`VMenu.js should render component with custom offsetX and match snapshot
exports[`VMenu.js should render component with custom offsetY and match snapshot 1`] = `

<div class="v-menu"
style="display: inline-block;"
style="display: block;"
>
<div class="v-menu__content"
style="max-height: auto; min-width: 0px; max-width: auto; top: 12px; left: 0px; z-index: 0; display: none;"
Expand All @@ -263,7 +263,7 @@ exports[`VMenu.js should render component with custom offsetY and match snapshot
exports[`VMenu.js should render component with custom openOnClick and match snapshot 1`] = `

<div class="v-menu"
style="display: inline-block;"
style="display: block;"
>
<div class="v-menu__content"
style="max-height: auto; min-width: 0px; max-width: auto; top: 12px; left: 0px; z-index: 0; display: none;"
Expand All @@ -276,7 +276,7 @@ exports[`VMenu.js should render component with custom openOnClick and match snap
exports[`VMenu.js should render component with custom openOnHover and match snapshot 1`] = `

<div class="v-menu"
style="display: inline-block;"
style="display: block;"
>
<div class="v-menu__content"
style="max-height: auto; min-width: 0px; max-width: auto; top: 12px; left: 0px; z-index: 0; display: none;"
Expand All @@ -289,7 +289,7 @@ exports[`VMenu.js should render component with custom openOnHover and match snap
exports[`VMenu.js should render component with custom origin and match snapshot 1`] = `

<div class="v-menu"
style="display: inline-block;"
style="display: block;"
>
<div class="v-menu__content"
style="max-height: auto; min-width: 0px; max-width: auto; top: 12px; left: 0px; z-index: 0; display: none;"
Expand All @@ -302,7 +302,7 @@ exports[`VMenu.js should render component with custom origin and match snapshot
exports[`VMenu.js should render component with custom positionX and match snapshot 1`] = `

<div class="v-menu"
style="display: inline-block;"
style="display: block;"
>
<div class="v-menu__content"
style="max-height: auto; min-width: 0px; max-width: auto; top: 12px; left: 0px; z-index: 0; display: none;"
Expand All @@ -315,7 +315,7 @@ exports[`VMenu.js should render component with custom positionX and match snapsh
exports[`VMenu.js should render component with custom positionY and match snapshot 1`] = `

<div class="v-menu"
style="display: inline-block;"
style="display: block;"
>
<div class="v-menu__content"
style="max-height: auto; min-width: 0px; max-width: auto; top: 12px; left: 0px; z-index: 0; display: none;"
Expand All @@ -328,7 +328,7 @@ exports[`VMenu.js should render component with custom positionY and match snapsh
exports[`VMenu.js should render component with custom right and match snapshot 1`] = `

<div class="v-menu"
style="display: inline-block;"
style="display: block;"
>
<div class="v-menu__content"
style="max-height: auto; min-width: 0px; max-width: auto; top: 12px; left: 0px; z-index: 0; display: none;"
Expand All @@ -341,7 +341,7 @@ exports[`VMenu.js should render component with custom right and match snapshot 1
exports[`VMenu.js should render component with custom top and match snapshot 1`] = `

<div class="v-menu"
style="display: inline-block;"
style="display: block;"
>
<div class="v-menu__content"
style="max-height: auto; min-width: 0px; max-width: auto; top: 12px; left: 0px; z-index: 0; display: none;"
Expand All @@ -354,7 +354,7 @@ exports[`VMenu.js should render component with custom top and match snapshot 1`]
exports[`VMenu.js should render component with custom transition and match snapshot 1`] = `

<div class="v-menu"
style="display: inline-block;"
style="display: block;"
>
<div class="v-menu__content"
style="max-height: auto; min-width: 0px; max-width: auto; top: 12px; left: 0px; z-index: 0; display: none;"
Expand All @@ -369,7 +369,7 @@ exports[`VMenu.js should round dimensions 1`] = `"max-height: auto; min-width: 1
exports[`VMenu.js should work 1`] = `

<div class="v-menu"
style="display: inline-block;"
style="display: block;"
>
<div class="v-menu__activator v-menu__activator--active">
<button type="button"
Expand Down
4 changes: 2 additions & 2 deletions test/unit/components/VOverflowBtn/__snapshots__/VOverflowBtn.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ exports[`VOverflowBtn should use default autocomplete selections 1`] = `
<div class="v-input__control">
<div class="v-input__slot">
<div class="v-menu"
style="display: inline-block;"
style="display: block;"
>
<div class="v-menu__activator">
<div class="v-select__slot">
Expand Down Expand Up @@ -50,7 +50,7 @@ exports[`VOverflowBtn should use default autocomplete selections 2`] = `
<div class="v-input__control">
<div class="v-input__slot">
<div class="v-menu"
style="display: inline-block;"
style="display: block;"
>
<div class="v-menu__activator">
<div class="v-select__slot">
Expand Down
Loading