feat(theme): add utility functions #20535
Open
+101
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I feel like this doesn't really add anything more useful than just making useTheme return a reactive(theme) instead would. |
Open to suggestions. The current process for working with themes directly is quite cumbersome; some form of update is necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request introduces new methods to
theme.tsfor enhanced theme management and updatestheme.mdto document these changes. The added methods will allow developers to better manage and switch themes at runtime.Changes Made:
theme.ts:get: Retrieve the current or a specified theme by name.update: Update the current color within a theme or a specified theme by name.register: Register a new theme with custom properties.set: Change the global theme.