Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(locale): memory leak with default rtl values #18975

Merged
merged 6 commits into from
Jan 10, 2024
Merged

fix(locale): memory leak with default rtl values #18975

merged 6 commits into from
Jan 10, 2024

Conversation

Jindorf
Copy link
Contributor

@Jindorf Jindorf commented Jan 4, 2024 •
edited
Loading

Description

resolves #18965

@Jindorf Jindorf changed the title fixed a bug causing rtl as a ref to cause a memory leak in ssr fix: a bug causing rtl as a ref to cause a memory leak in ssr #18965 Jan 4, 2024
@Jindorf Jindorf marked this pull request as draft January 4, 2024 12:40
@Jindorf Jindorf marked this pull request as ready for review January 4, 2024 13:05
@johnleider
Copy link
Member

What is your test process for checking the leak? Realistically the fix for this is to turn these defaults into a factory function:

image

@Jindorf
Copy link
Contributor Author

Jindorf commented Jan 9, 2024

Thanks for the reply!
I think I called out every step i took inside the issue. I also provided a reproduction inside.
I installed a plain nuxt project, installed vuetify as in the docs, then ran the clinic test i provided in the package.json.
After that i changed the vuetify code and ran the test again.
If you need any more information, I'll try to help as best as I can.

@johnleider
Copy link
Member

Okay, thank you. My suggestion is to check our findings against a fix that only requires turning those defaults from an object into an function that returns an object.

@Jindorf
Copy link
Contributor Author

Jindorf commented Jan 10, 2024

@johnleider your suggestion also fixes the leak.

reverting my previous changes, 60s test:
image

applying your suggestions, 60s test:
image

@johnleider johnleider merged commit 5b07a9f into vuetifyjs:master Jan 10, 2024
10 checks passed
@johnleider johnleider added this to the v3.4.x milestone Jan 10, 2024
@johnleider johnleider added T: bug Functionality that does not work as intended/expected E: locale Locale composable labels Jan 10, 2024
@johnleider johnleider changed the title fix: a bug causing rtl as a ref to cause a memory leak in ssr #18965 fix(locale): memory leak with default rtl values Jan 10, 2024
tmasrat pushed a commit to tmasrat/vuetify that referenced this pull request Jan 22, 2024
@Jindorf @johnleider @tmasrat
fix(locale): memory leak with default rtl values vuetifyjs#18965 (vue…
100fb20 
…tifyjs#18975)

fixes vuetifyjs#18965

Co-authored-by: Indorf, Jannik <jannik.indorf@eventim.de>
Co-authored-by: John Leider <john@vuetifyjs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnleider johnleider johnleider approved these changes

Assignees

@Jindorf Jindorf

Labels
E: locale Locale composable T: bug Functionality that does not work as intended/expected
Projects
None yet
Milestone
v3.4.x
Development

Successfully merging this pull request may close these issues.

[Bug Report][3.4.9] SSR memory leak
2 participants
@Jindorf @johnleider