Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VCombobox/VAutocomplete): Only allow input to completely overlap selection when focused #18817

Merged
merged 4 commits into from
Dec 11, 2023

Conversation

yuwu9145
Copy link
Member

@yuwu9145 yuwu9145 commented Dec 4, 2023

fixes #18796

Description

Markup:

<template>
  <v-app>
    <v-container>
      <v-autocomplete
        chips
        v-model="state"
        closable-chips
        label="Autocomplete"
        :items="['California', 'Colorado', 'Florida', 'Georgia', 'Texas', 'Wyoming']"
      ></v-autocomplete>
      <v-combobox
        chips
        closable-chips
        v-model="state"
        label="Combobox"
        :items="['California', 'Colorado', 'Florida', 'Georgia', 'Texas', 'Wyoming']"
      />
      <v-select
        chips
        closable-chips
        v-model="state"
        label="Select"
        :items="['California', 'Colorado', 'Florida', 'Georgia', 'Texas', 'Wyoming']"
      />
    </v-container>
  </v-app>
</template>

<script setup>
  import { ref } from 'vue'

  const state = ref('California')
</script>

@yuwu9145 yuwu9145 marked this pull request as draft December 4, 2023 12:05
@MajesticPotatoe MajesticPotatoe added T: bug Functionality that does not work as intended/expected C: VCombobox VCombobox C: VAutocomplete VAutocomplete labels Dec 6, 2023
@yuwu9145 yuwu9145 self-assigned this Dec 7, 2023
@yuwu9145 yuwu9145 marked this pull request as ready for review December 9, 2023 10:40
@yuwu9145 yuwu9145 requested review from johnleider and KaelWD December 9, 2023 10:40
@johnleider johnleider added this to the v3.4.x milestone Dec 11, 2023
@johnleider johnleider merged commit 5fcdeb0 into master Dec 11, 2023
17 of 18 checks passed
@johnleider johnleider deleted the fix-18796 branch December 11, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VAutocomplete VAutocomplete C: VCombobox VCombobox T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report][3.4.4] Can't close the chip on V-autocomplete
3 participants