Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VOverlay): apply min-width #17050

Conversation

HIROYUKI20200507
Copy link
Contributor

Description

Markup:

packages/vuetify/dev/Playground.vue

<template>
  <v-app>
    <v-container>
      <div class="text-center">
        <v-menu :min-width="500">
          <template v-slot:activator="{ props }">
            <v-btn v-bind="props"> Dropdown </v-btn>
          </template>
          <v-list>
            <v-list-item>
              <v-list-item-title>Here</v-list-item-title>
            </v-list-item>
          </v-list>
        </v-menu>
      </div>
    </v-container>
  </v-app>
</template>

<script>
  export default {
    name: 'Playground',
    setup () {
      return {
        //
      }
    },
  }
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

Comment

Hey, hello there!
Sorry for the suddenness.

I tried fixing the relevant part we were discussing. What do you think?
I'd appreciate any comments you have.
Thanks for taking a look!

@KaelWD KaelWD force-pushed the master branch 3 times, most recently from aa22a14 to ca89962 Compare April 13, 2023 11:01
@johnleider johnleider added T: bug Functionality that does not work as intended/expected C: VMenu VMenu labels Apr 19, 2023
@johnleider johnleider requested a review from KaelWD April 19, 2023 16:13
@johnleider johnleider added this to the v3.x.x milestone Apr 19, 2023
@johnleider johnleider changed the title fix(VBtn): Resolved the issue where min-width was not working in the dropdown fix(VOverlay): apply min-width Apr 19, 2023
@KaelWD KaelWD force-pushed the master branch 12 times, most recently from 7c417af to 070e2aa Compare May 24, 2023 13:23
@johnleider johnleider added the S: has merge conflicts The pending Pull Request has merge conflicts label Jul 7, 2023
Copy link
Member

@KaelWD KaelWD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default min-width is supposed to be the width of the activator
Screenshot_20230714_194051

@johnleider
Copy link
Member

@HIROYUKI20200507 any updates?

@johnleider johnleider added the S: stale This issue is untriaged and hasn't seen any activity in at least six months. label Aug 8, 2023
@johnleider
Copy link
Member

This Pull Request is being closed due to inactivity.

If you have any additional questions, please reach out to us in our Discord community.

@johnleider johnleider closed this Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VMenu VMenu S: has merge conflicts The pending Pull Request has merge conflicts S: stale This issue is untriaged and hasn't seen any activity in at least six months. T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants