fix: check if CSS.supports exists #16984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnleider
approved these changes
Mar 23, 2023
johnleider
added
T: bug
kingyue737
added a commit
to kingyue737/vitify-next
that referenced
this pull request
Mar 29, 2023
kingyue737
added a commit
to kingyue737/vitify-electron
that referenced
this pull request
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CSS.supportcheckup now fails with some environments. I suggest adding an extra check on its existence similar to the way it's done in many other projects.Specifically, I was checking it with
nuxt-vitest(it useshappy-dom).The issue it produces is similar to that one wojtekmaj/react-fit#2
This fix made earlier seems to be not enough
59370b0
Markup: