fix(display): add hydrate checks for getPlatform #16828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnleider
added
T: bug
KaelWD
reviewed
Mar 7, 2023
Comment on lines
+178
to
+180
| const mobile = !platform.value.ssr | ||
| ? width.value < breakpointValue | ||
| : platform.android || platform.ios || platform.opera | ||
| : platform.value.android || platform.value.ios || platform.value.opera |
There was a problem hiding this comment.
Unrelated but this seems kinda off. If ssr the other three will always be false, so really it's just checking width < mobileBreakpoint except that would be true for ssr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
fixes #16825
Markup
Not sure the best way to test this but from @KaelWD's comment, I assume this is the fix