-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(VGrid): fix breakpoints types #16708
Conversation
e78f69e
to
b7f3349
Compare
e2cc799
to
c5799b5
Compare
I think the script should be a separate PR. @KaelWD needs to chime in on this as well. |
@KaelWD I can easily separate the script part into an independent PR if you want |
Script has been move to PR #16843 |
@@ -0,0 +1,3 @@ | |||
export const breakpoints = ['sm', 'md', 'lg', 'xl', 'xxl'] as const // no xs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to come up with a way to propagate this sizing information as part of the framework simply because of how many places it is used in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After thinking on this, I felt the most natural place would be within the display composable. What do you think @vuetifyjs/core-team ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make feedback process smooth, I moved breakpoints to display composable. I also did a local testing via |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fix #16604
Description
resolves #16604
Markup: