Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VColorPicker): support dynamic width #16675

Merged
merged 3 commits into from
Feb 21, 2023
Merged

Conversation

KaelWD
Copy link
Member

@KaelWD KaelWD commented Feb 15, 2023

Description

Fixes #7151
Fixes #16668

Markup:

<template>
  <v-app>
    <v-main class="ps-12">
      <v-color-picker v-model="pickerValueTop" width="100%" />
      <br>
      Top picker value: {{ pickerValueTop }}
      <br>
      <br>
      <v-color-picker v-model="pickerValueBottom" width="300" />
      <br>
      Bottom picker value: {{ pickerValueBottom }}
    </v-main>
  </v-app>
</template>

<script setup>
  import { ref } from 'vue'

  const pickerValueTop = ref('#f00')
  const pickerValueBottom = ref('#f00')
</script>

@KaelWD KaelWD added T: bug Functionality that does not work as intended/expected C: VColorPicker labels Feb 15, 2023
@KaelWD KaelWD added this to the v3.1.x milestone Feb 15, 2023
@KaelWD KaelWD requested a review from nekosaur February 15, 2023 13:01
@KaelWD KaelWD self-assigned this Feb 15, 2023
@nekosaur
Copy link
Member

<template>
  <v-app>
    <v-main class="pa-12">
      <v-window
        v-model="window"
        show-arrows
      >
        <v-window-item
          v-for="n in length"
          :key="n"
        >
          <v-card class="d-flex justify-center align-center">
            <v-color-picker width="100%" />
          </v-card>
        </v-window-item>
      </v-window>
    </v-main>
  </v-app>
</template>

<script setup>
  import { ref } from 'vue'

  const length = ref(2)
  const window = ref()
</script>

go to next slide, then go back

@KaelWD KaelWD merged commit 7190d27 into master Feb 21, 2023
@KaelWD KaelWD deleted the fix/color-picker-dynamic-width branch February 21, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VColorPicker T: bug Functionality that does not work as intended/expected
Projects
None yet
3 participants