fix for #1304

[chancet1982]

This fix is intended to solve 2 issues:

1. The "noDataText" tile isnt clickable, and that is hardcoded. Instead it should look for a prop "no-data-clickable" which is by default false for its "disabled" state.
2. Instead of hardcoded value for "noDataText" (which is language specific) when generating the noDataText tile the value can be set to any string, using the prop no-data-value

[johnleider]

I'm okay with these changes but there are a few notes:

• Can you please add tests that verify this functionality
• What is the intended behavior for v-data-table which also implements the filterable mixin

[chancet1982]

Regarding your question. I think current behavior of v-data-table is fine. I think the enhancement is only relevant for the v-select. Regarding the tests - I cant seem to run the tests locally using "npm test" is there anything im missing?

[johnleider]

You need to have jest installed globally I believe, but without seeing the error, I'm not sure.

[chancet1982]

Tests dont seem to currently work on combination of windows 10, Git Bash, and Jest. Adding -i to the configuration seems to solve it.

Link to thread:
jestjs/jest#3079

[johnleider]

I think you can remove the need for no-data-value as it already accepts no-data-text.

[chancet1982]

Hi, sorry but I am quite a crappy test writer as it seems... I dont think ill be able to right now. ill explain the logic I had with adding a value to the "no data" tile and you can decide if you wish to take these changes and write the tests or dump the idea altogether...
I basically made 2 changes:

1. no datatext clickable as a prop instead of hardcoded.
2. the nodatatext as it is today is language specific, comparing a value string which is not language dependent is simpler -if the prop is not used then no harm done :)

Once more apologize but will not be able to write the tests.

[johnleider]

No worries, I'll take it from here.

[johnleider]

I have resolved this differently, ty for the contribution.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord