-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(VSnackbar): add new properties and improve md2 spec #11542
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnleider
added
C: VSnackbar
T: bug
Functionality that does not work as intended/expected
T: feature
A new feature
labels
Jun 1, 2020
Requesting Initial comments from @vuetifyjs/contributors @vuetifyjs/core-team |
This was
linked to
issues
Jun 1, 2020
Hey @johnleider, TravisBuddy Request Identifier: 13c9d410-a5b1-11ea-84d7-9d6761bd5292 |
johnleider
force-pushed
the
feat/snackbar-improvements
branch
2 times, most recently
from
June 2, 2020 02:28
6c869ee
to
2aae2c2
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
KaelWD
reviewed
Jun 2, 2020
johnleider
force-pushed
the
feat/snackbar-improvements
branch
from
June 2, 2020 17:13
d27fddb
to
deb1a71
Compare
johnleider
force-pushed
the
feat/snackbar-improvements
branch
3 times, most recently
from
June 2, 2020 19:57
deb1a71
to
864ca75
Compare
Requesting Final comments from @vuetifyjs/contributors @vuetifyjs/core-team |
added support for elevation, rounded, and theme
johnleider
force-pushed
the
feat/snackbar-improvements
branch
from
June 2, 2020 23:59
a7fc1b2
to
f9daa0c
Compare
dsseng
reviewed
Jun 3, 2020
This was referenced Jun 3, 2020
This was referenced Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added support for elevation, rounded, and theme
Description
Changed the default value for timeout from
6000
to5000
to match specification. Changed the value to disable the timeout from0
to-1
. The timeout property now accepts strings and is converted usingNumber
.Added new scoped slot that provides attributes for
v-btn
styling.Added and deprecated multiple SASS variables.
Added the following new props:
Also refactored all tests.
Motivation and Context
Improve
v-snackbar
heading into LTS.fixes #10935
fixes #5865
How Has This Been Tested?
Markup:
Types of changes
Checklist:
master
for bug fixes and documentation updates,dev
for new features and backwards compatible changes andnext
for non-backwards compatible changes).