Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report][3.6.9] VTreeview: Append/Prepend Slots not usable on parent nodes when activatable #20009

Closed
ConnorNoddin opened this issue Jun 14, 2024 · 8 comments · May be fixed by Equoa1/Thiio-Laravel-Vue#1, jonathanestefani/crud_vuetify#5 or aurelienfvre/sae401#1
Assignees
Labels
C: VTreeview VTreeview T: bug Functionality that does not work as intended/expected

Comments

@ConnorNoddin
Copy link

Environment

Vuetify Version: 3.6.9
Vue Version: 3.4.27
Browsers: Chrome 125.0.0.0
OS: Windows 10

Steps to reproduce

  1. Create a VTreeview node.
  2. Make the VTreeview activatable
  3. Add a template using the append or prepend slots
  4. In the template, insert a node

The node will not be visible in parent nodes on the tree. It will be visible for child nodes.

Expected Behavior

The nodes append and prepend to parent nodes in the tree.

Actual Behavior

The nodes do not append or prepend to parent nodes in the tree.

Reproduction Link

https://play.vuetifyjs.com/#...

Other comments

Note, using selected instead of activatable works fine. Using neither selected nor activatable also works fine.

@jelle-eastground
Copy link

I have experienced the same problem: icons defined in the prepend slot are only visible in leaf nodes. This problem also appears in the example in the documentation. Version 3.6.7 works, 3.6.8 or newer doesn't.

@ConnorNoddin
Copy link
Author

I have experienced the same problem: icons defined in the prepend slot are only visible in leaf nodes. This problem also appears in the example in the documentation. Version 3.6.7 works, 3.6.8 or newer doesn't.

I'm not sure the "activatable" keyword is available in 3.6.7? It appears when using that Vuetify version that the keyword has no effect

@yuwu9145
Copy link
Member

I'm not sure the "activatable" keyword is available in 3.6.7? It appears when using that Vuetify version that the keyword has no effect

There was a select/activate regression in v3.6.7 #20024, it's been fixed, cy tests are also added to prevent it happens again.

Stay tuned for next release

@ConnorNoddin
Copy link
Author

@yuwu9145 After testing the new release, v3.6.11, the example that was originally posted still does not work with the icons.

@yuwu9145
Copy link
Member

yuwu9145 commented Jul 3, 2024

@yuwu9145 After testing the new release, v3.6.11, the example that was originally posted still does not work with the icons.

What I meant specifically was activate/select regression, I quoted your "activatable" keyword in my previous comment. This issue is more about slot in ItemGroup. I am doing Treeview enhancement recently, it should be fixed soon

@ConnorNoddin
Copy link
Author

@yuwu9145 Awesome! I am most excited!

@KaelWD KaelWD added T: bug Functionality that does not work as intended/expected C: VTreeview VTreeview labels Jul 8, 2024
@github-actions github-actions bot removed the S: triage label Jul 8, 2024
@github-actions github-actions bot closed this as completed Jul 9, 2024
@ConnorNoddin
Copy link
Author

@yuwu9145 While you were working on your recent merge request, did you notice that the VTreeview search functionality doesn't appear to work? Maybe I am using it wrong https://vuetifyjs.com/en/components/treeview/#search-and-filter

@yuwu9145
Copy link
Member

yuwu9145 commented Jul 11, 2024

Didn't notice, let's track it in #19404

It's mostly working on dev branch, though "Case sensitive search" doesn't work

treeview-search

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment