Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report][3.6.4] v-dialog fullscreen not working when width it's set #19915

Closed
ghimisradu opened this issue May 28, 2024 · 0 comments · Fixed by #20554
Closed

[Bug Report][3.6.4] v-dialog fullscreen not working when width it's set #19915

ghimisradu opened this issue May 28, 2024 · 0 comments · Fixed by #20554
Labels
C: VDialog VDialog T: bug Functionality that does not work as intended/expected
Milestone
v3.7.x

Comments

@ghimisradu
Copy link

Environment

Vuetify Version: 3.6.4
Vue Version: 3.4.27
Browsers: Chrome 125.0.0.0
OS: Windows 10

Steps to reproduce

Check the playground and open the dialog and click the fullscreen button inside the dialog.

Expected Behavior

If the fullscreen property it's set, the dialog width property should be ignored

Actual Behavior

When the fullscreen it's set the dialog respects the width property, resulting in dialog being wrongly shown on left side of the page

Reproduction Link

https://play.vuetifyjs.com/#...
Jesse205 added a commit to Jesse205/vuetify that referenced this issue Oct 3, 2024
@Jesse205
fix(VDialog): remove height and width when fullscreen
d615a0f 
fixes vuetifyjs#19915
@Jesse205 Jesse205 mentioned this issue Oct 3, 2024
Merged
Jesse205 added a commit to Jesse205/vuetify that referenced this issue Oct 13, 2024
@Jesse205
fix(VDialog): remove height and width when fullscreen
0cd7bf9 
fixes vuetifyjs#19915
@KaelWD KaelWD added T: bug Functionality that does not work as intended/expected C: VDialog VDialog labels Nov 6, 2024
@KaelWD KaelWD added this to the v3.7.x milestone Nov 6, 2024
@github-actions github-actions bot removed the S: triage label Nov 6, 2024
KaelWD pushed a commit that referenced this issue Nov 6, 2024
@Jesse205
fix(VDialog): ignore size props when fullscreen (#20554)
3adcbef 
fixes #19915
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: VDialog VDialog T: bug Functionality that does not work as intended/expected
Projects
None yet
Milestone
v3.7.x
Development

Successfully merging a pull request may close this issue.

fix(VDialog): ignore size props when fullscreen Jesse205/vuetify
2 participants
@KaelWD @ghimisradu