Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report][3.4.7] VPagination ARIA attributes on buttons do not render correctly #18885

Closed
tahornback opened this issue Dec 15, 2023 · 7 comments · Fixed by #18886
Closed
Labels
a11y Accessibility issue T: bug Functionality that does not work as intended/expected
Milestone

Comments

@tahornback
Copy link
Contributor

Environment

Vuetify Version: 3.4.7
Vue Version: 3.3.11
Browsers: Chrome 119.0.0.0
OS: Mac OS 10.15.7

Steps to reproduce

Use a VPagination component, view the generated HTML (without browser interference)

Expected Behavior

buttons in a VPagination have aria-label and aria-disabled attributes

Actual Behavior

buttons in a VPagination do not have aria-label and aria-disabled attributes, but instead arialabel and ariadisabled attributes

Reproduction Link

https://github.com/tahornback/vuetify-vpagination-issue

Other comments

I discovered this when working with VDataTable, which was converted to using VPagination in 3.4.2.

@johnleider
Copy link
Member

What am I supposed to do with the repository to reproduce the issue?

@tahornback
Copy link
Contributor Author

I have updated the repo with a bit more information, documenting HTML behavior, JS behavior, and better outlining current and expected behaviors. Since it seems like the browser does some magic to cover up the issue, I'm not sure how to reproduce without staying in a test environment. If direct Vue HTML generation is needed to "prove" the issue, I'll try to find a way. I'm not familiar enough to know other ways of demonstrating the issue.

@johnleider
Copy link
Member

@KaelWD Is this a non-issue?

@tahornback
Copy link
Contributor Author

I do not see any other instances of an ARIA attribute being used in a camelCase style. Everything I've seen in kebab-case, such as

  • VAlert.tsx:141
  • VBase.tsx:89-91
  • VChip.tsx:142
  • VTab.tsx:118

@websitevirtuoso
Copy link
Contributor

maybe unit test can help to check this issue? At least I think so

@johnleider
Copy link
Member

A single search returned this:
image

@tahornback
Copy link
Contributor Author

I just threw together a test quick over lunch w/ VWindow, appears to behave similarly to VPagination. I will add tests to the reproduction repo.

describe('VWindow', () => {
    it('renders with arialabel', () => {
        render(VWindow, {
            global: {
                plugins: [vuetify]
            },
            props: {
                showArrows: true
            }
        })

        screen.debug()
    })
})
<body>
  <div>
    <div
      class="v-window v-theme--light"
    >
      <div
        class="v-window__container"
      >
        <div
          class="v-window__controls"
        >
          
          <button
            arialabel="Previous visual"
            class="v-btn v-btn--elevated v-btn--icon v-theme--light v-btn--density-default v-btn--size-default v-btn--variant-elevated v-window__left"
            type="button"
          >
            
            <span
              class="v-btn__overlay"
            />
            <span
              class="v-btn__underlay"
            />
            
            <span
              class="v-btn__content"
              data-no-activator=""
            >
              <i
                aria-hidden="true"
                class="mdi-chevron-left mdi v-icon notranslate v-theme--light v-icon--size-default"
              />
            </span>
          </button>
          <div />
          
        </div>
      </div>
    </div>
  </div>
</body>

tahornback added a commit to tahornback/vuetify that referenced this issue Jan 16, 2024
@KaelWD KaelWD added T: bug Functionality that does not work as intended/expected a11y Accessibility issue labels Jan 16, 2024
@KaelWD KaelWD added this to the v3.4.x milestone Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility issue T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants