Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report][3.0.0-beta.1] The badge does not get a round shape when you use an icon prop. #14991

Closed
alokVishu opened this issue Apr 25, 2022 · 0 comments
Closed

[Bug Report][3.0.0-beta.1] The badge does not get a round shape when you use an icon prop. #14991

alokVishu opened this issue Apr 25, 2022 · 0 comments
Assignees
@KaelWD
Labels
C: VBadge VBadge T: bug Functionality that does not work as intended/expected
Milestone
v3.0.0-beta

Comments

@alokVishu
Copy link
Contributor

Environment

Vuetify Version: 3.0.0-beta.1
Vue Version: 3.2.33
Browsers: Chrome 100.0.4896.127
OS: Windows 10

Steps to reproduce

Just put an icon prop to the badge.

Expected Behavior

It should be a nice rounded shape and the icon should be a little small

Actual Behavior

The icon looks too big and the badge has no shape.

Reproduction Link

https://codepen.io/Alokdev/pen/rNpgqPY?editors=101

image
@ElijahKotyluk ElijahKotyluk added the C: VBadge VBadge label Apr 28, 2022
volvachev added a commit to volvachev/vuetify that referenced this issue May 6, 2022
@volvachev
fix(VBadge): round shape when were used icon prop
b9a147d 
The badge does not get a round shape when you use an icon prop

fixes vuetifyjs#14991
@volvachev volvachev mentioned this issue May 6, 2022
Closed
8 tasks
@KaelWD KaelWD added T: bug Functionality that does not work as intended/expected and removed S: triage labels May 9, 2022
@KaelWD KaelWD added this to the v3.0.0-beta milestone May 9, 2022
volvachev added a commit to volvachev/vuetify that referenced this issue May 9, 2022
@volvachev
fix(VBadge): round shape when were used icon prop
3fc5716 
The badge does not get a round shape when you use an icon prop

fixes vuetifyjs#14991
@KaelWD KaelWD self-assigned this May 23, 2022
KaelWD added a commit that referenced this issue May 23, 2022
@KaelWD
fix(VBadge): correct icon size and padding
bc7d409 
fixes #14991
johnleider added a commit that referenced this issue Mar 27, 2023
@johnleider
fix(VBadge): add removed display css property
8f8f2ea 
fixes #12083

broken by bc7d409 confirmed #14991 is still
good
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KaelWD KaelWD

Labels
C: VBadge VBadge T: bug Functionality that does not work as intended/expected
Projects
None yet
Milestone
v3.0.0-beta
Development

No branches or pull requests
3 participants
@KaelWD @ElijahKotyluk @alokVishu