Skip to content

Commit

Permalink
style(dimensions.ts): reduce code complexity
Browse files Browse the repository at this point in the history
  • Loading branch information
johnleider committed Jan 26, 2021
1 parent 04ac764 commit f2b5efc
Showing 1 changed file with 8 additions and 21 deletions.
29 changes: 8 additions & 21 deletions packages/vuetify/src/composables/dimensions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@ export interface DimensionProps {
width?: number | string
}

type DimensionKey = keyof DimensionProps
type DimensionStyles = Partial<Record<DimensionKey, string>>

// Composables
export const makeDimensionProps = propsFactory({
height: [Number, String],
Expand All @@ -27,24 +24,14 @@ export const makeDimensionProps = propsFactory({
})

export function useDimension (props: DimensionProps) {
const dimensionStyles = computed(() => {
const styles: DimensionStyles = {}
const height = convertToUnit(props.height)
const maxHeight = convertToUnit(props.maxHeight)
const maxWidth = convertToUnit(props.maxWidth)
const minHeight = convertToUnit(props.minHeight)
const minWidth = convertToUnit(props.minWidth)
const width = convertToUnit(props.width)

if (height) styles.height = height
if (maxHeight) styles.maxHeight = maxHeight
if (maxWidth) styles.maxWidth = maxWidth
if (minHeight) styles.minHeight = minHeight
if (minWidth) styles.minWidth = minWidth
if (width) styles.width = width

return styles
})
const dimensionStyles = computed(() => ({
height: convertToUnit(props.height),
maxHeight: convertToUnit(props.maxHeight),
maxWidth: convertToUnit(props.maxWidth),
minHeight: convertToUnit(props.minHeight),
minWidth: convertToUnit(props.minWidth),
width: convertToUnit(props.width),
}))

return { dimensionStyles }
}

0 comments on commit f2b5efc

Please sign in to comment.