-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up webpack build #54
Conversation
We had a lower-maintenance version of this previously: 3fea882 It may cause css problems as there is no longer a defined import order. |
@KaelWD It looks like that since your previous lower-maintenance version, you made imports sorted (https://github.com/vuetifyjs/vuetify-loader/blob/master/lib/loader.js#L31) could it prevent any css issue ? I don't know much about the importance of css import orders but webpack build definitely need speed up, as for now a single Maybe it's an issue regarding how are exported components in vuetify/lib ? I know that some ways of using |
That was to fix vuetifyjs/vuetify#5271, didn't work We do still have ordering problems (vuetifyjs/vuetify#3583) so maybe it won't be a problem. Either way I'd prefer to use my original code without hard-coded workarounds, we added structures to the vuetify repo specifically for this reason. |
@KaelWD I totally agree around the added structures, but something that is annoying is that Webpack seems to just go crazy and load/process everything when you simply do For a little project which use only few components, ther's probably 80% unwanted webpack processing (lot of reached files which will be never used, it includes the loading and processing of unwanted SASS files of all components). I think the issue has something to do with exports somewhere. |
I'm referring to 3fea882 of course Webpack processes everything and marks what's actually unused, then the minifier actually removes unused code. |
Oh alright, I thought it was a performance issue (seeing all the Vuetify file names processed in Webpack bar progress) |
Thanks for taking the time to do this @bru02. I've merged it into a feature branch for now because there's some changes I want to make before release. |
Is this still something you are pursuing @KaelWD ? |
No, it was released in 1.3 |
Implement #44