Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: load default address in checkout #5788

Merged

Conversation

lukaszjedrasik
Copy link
Contributor

Related Issues

closes #4682

Short Description of the PR

If shipping data are available for this account, the shipping form will be filled automatically.

Screenshots of Visual Changes before/after (if There Are Any)

Default theme:
https://user-images.githubusercontent.com/40273258/115393821-6559d900-a1e2-11eb-8a1a-0ac55c1b0ce3.mp4

Capybara theme:
https://user-images.githubusercontent.com/40273258/115393892-79053f80-a1e2-11eb-857c-e95d3e841843.mp4

Pull Request Checklist

  • I have updated the Changelog (V1) v2 and mentioned all breaking changes in the public API.
  • I have documented all new public APIs and made changes to existing docs mentioning the parts I've changed so they're up to date.
  • I have tested my Pull Request on production build and (to my knowledge) it works without any issues

@lukaszjedrasik lukaszjedrasik added the VSF1 Issues in regards to VSF1 label Apr 20, 2021
Copy link
Collaborator

@Fifciu Fifciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It requires solid manualy testing. I am afraid this watcher will be invoked on every step of the checkout as Shipping.vue is mounted all the time on the checkout (at least it was)

@Fifciu Fifciu merged commit bd24d6c into hotfix/v1.12.3 Apr 21, 2021
@lukaszjedrasik lukaszjedrasik deleted the #4682-fix/incorrect-load-of-default-address-in-checkout branch April 21, 2021 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
VSF1 Issues in regards to VSF1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants